Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release search context when scroll keep_alive is too large #62179

Merged
merged 4 commits into from
Sep 9, 2020
Merged

Release search context when scroll keep_alive is too large #62179

merged 4 commits into from
Sep 9, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 9, 2020 •
edited
Loading

Previously, we close related search contexts if the keep_alive of a scroll is too large. But we accidentally change this behavior in #62061.

CI: https://gradle-enterprise.elastic.co/s/f2aczys5rxvik/console-log/raw

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.10.0 labels Sep 9, 2020
@dnhatn dnhatn requested a review from jimczi September 9, 2020 15:49
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 9, 2020
@dnhatn dnhatn added >non-issue and removed >test Issues or PRs that are addressing/adding tests labels Sep 9, 2020
@dnhatn dnhatn changed the title Fix testInvalidScrollKeepAlive Release search context when scroll keep_alive is too large Sep 9, 2020
@dnhatn
Copy link
Member Author

dnhatn commented Sep 9, 2020

@jimczi I've updated the PR.

jimczi
jimczi approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small comments but the fix looks good to me.

server/src/main/java/org/elasticsearch/search/SearchService.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/search/SearchService.java Outdated Show resolved Hide resolved
@dnhatn
Copy link
Member Author

dnhatn commented Sep 9, 2020

Thanks Jim!

@dnhatn dnhatn merged commit 4e974bc into elastic:master Sep 9, 2020
@dnhatn dnhatn deleted the fix-scroll-keep-alive-test branch September 9, 2020 18:45
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Sep 10, 2020
@dnhatn
Release search context when scroll keep_alive is too large (elastic#6…
28a3480 
…2179)

Previously, we close related search contexts if the keep_alive of a scroll is too large. 
But we accidentally change this behavior in elastic#62061.
dnhatn added a commit that referenced this pull request Sep 10, 2020
@dnhatn
Release search context when scroll keep_alive is too large (#62179)
063a6d0 
Previously, we close related search contexts if the keep_alive of a scroll is too large. 
But we accidentally change this behavior in #62061.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimczi jimczi jimczi approved these changes

Assignees
No one assigned
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnhatn @elasticmachine @jimczi @jakelandis